Changeset 520b4a3 in guacamole

Timestamp:

04/18/12 15:02:23 (13 months ago)

Author:

Michal Kotas <miko@…>

Branches:

master, guacamole-debian-parent, rpm, unstable, unstable-websocket

Children:

7545277

Parents:

729e196

git-author:

Michal Kotas <miko@…> (04/18/12 15:01:34)

git-committer:

Michael Jumper <zhangmaike@…> (04/18/12 15:02:23)

Message:

Implement multiple authorized connections per user.

Files:

• doc/example/user-mapping.xml (modified) (2 diffs)
• src/main/java/net/sourceforge/guacamole/net/basic/BasicFileAuthenticationProvider.java (modified) (12 diffs)

doc/example/user-mapping.xml

@@ -3 +3 @@
     <!-- Per-user authentication and config information -->
     <authorize username="USERNAME" password="PASSWORD">
-        <protocol>vnc</protocol>
-        <param name="hostname">localhost</param>
-        <param name="port">5900</param>
-        <param name="password">VNCPASS</param>
+
+        <!-- Single authorized connection -->
+                <remote-server servername="localhost">
+            <protocol>vnc</protocol>
+            <param name="hostname">localhost</param>
+            <param name="port">5900</param>
+            <param name="password">VNCPASS</param>
+        </remote-server>
+
     </authorize>
 
@@ -15 +20 @@
             password="319f4d26e3c536b5dd871bb2c52e3178"
             encoding="md5">
-        <protocol>vnc</protocol>
-        <param name="hostname">localhost</param>
-        <param name="port">5901</param>
-        <param name="password">VNCPASS</param>
-    </authorize>
+
+        <!-- First authorized connection -->
+                <remote-server servername="localhost">
+            <protocol>vnc</protocol>
+            <param name="hostname">localhost</param>
+            <param name="port">5901</param>
+            <param name="password">VNCPASS</param>
+        </remote-server>
+
+        <!-- Second authorized connection -->
+                <remote-server servername="otherhost">
+            <protocol>vnc</protocol>
+            <param name="hostname">otherhost</param>
+            <param name="port">5900</param>
+            <param name="password">VNCPASS</param>
+        </remote-server>
+
+ </authorize>
 
 </user-mapping>

src/main/java/net/sourceforge/guacamole/net/basic/BasicFileAuthenticationProvider.java

@@ -47 +47 @@
 /**
  * Authenticates users against a static list of username/password pairs.
- * Each username/password may be associated with exactly one configuration.
+ * Each username/password may be associated with multiple configurations.
  * This list is stored in an XML file which is reread if modified.
  * 
- * @author Michael Jumper
+ * This is modified version of BasicFileAuthenticationProvider written by Michael Jumper.
+ * 
+ * @author Michal Kotas
  */
 public class BasicFileAuthenticationProvider implements AuthenticationProvider {
@@ -137 +139 @@
         AuthInfo info = mapping.get(credentials.getUsername());
         if (info != null && info.validate(credentials.getUsername(), credentials.getPassword())) {
-            Map<String, GuacamoleConfiguration> configs = new HashMap<String, GuacamoleConfiguration>();
-            configs.put("DEFAULT", info.getConfiguration());
+            
+            //Map<String, GuacamoleConfiguration> configs = new HashMap<String, GuacamoleConfiguration>();
+            //configs.put("DEFAULT", info.getConfiguration());
+            //return configs;
+            
+            Map<String, GuacamoleConfiguration> configs = info.getConfigurations();          
             return configs;
         }
@@ -158 +164 @@
         private Encoding auth_encoding;
 
-        private GuacamoleConfiguration config;
+        private Map<String, GuacamoleConfiguration> configs;
 
         public AuthInfo(String auth_username, String auth_password, Encoding auth_encoding) {
@@ -165 +171 @@
             this.auth_encoding = auth_encoding;
 
-            config = new GuacamoleConfiguration();
+            configs = new HashMap<String, GuacamoleConfiguration>();
         }
 
@@ -221 +227 @@
         }
 
-        public GuacamoleConfiguration getConfiguration() {
-            return config;
+        public GuacamoleConfiguration getConfiguration(String name) {
+            //return configs;
+            return configs.get(name);
+        }
+        public Map<String, GuacamoleConfiguration> getConfigurations() {
+            return configs;
+        }
+        public void addConfiguration(String name) {
+            configs.put(name, new GuacamoleConfiguration());
         }
 
     }
-
 
     private static class BasicUserMappingContentHandler extends DefaultHandler {
@@ -239 +251 @@
             ROOT,
             USER_MAPPING,
+            REMOTE_SERVER,
             AUTH_INFO,
             PROTOCOL,
@@ -248 +261 @@
         private AuthInfo current = null;
         private String currentParameter = null;
+        private String currentRemoteServer = null;
 
         @Override
@@ -254 +268 @@
             switch (state)  {
 
-                case USER_MAPPING:
-
-                    if (localName.equals("user-mapping")) {
-                        state = State.END;
-                        return;
-                    }
-
-                    break;
-
-                case AUTH_INFO:
-
-                    if (localName.equals("authorize")) {
-
-                        // Finalize mapping for this user
-                        authMapping.put(
-                            current.auth_username,
-                            current
-                        );
-
-                        state = State.USER_MAPPING;
-                        return;
-                    }
-
-                    break;
-
-                case PROTOCOL:
-
-                    if (localName.equals("protocol")) {
-                        state = State.AUTH_INFO;
-                        return;
-                    }
-
-                    break;
-
-                case PARAMETER:
-
-                    if (localName.equals("param")) {
-                        state = State.AUTH_INFO;
-                        return;
-                    }
-
-                    break;
-
-            }
+            case USER_MAPPING:
+
+                if (localName.equals("user-mapping")) {
+                    state = State.END;
+                    return;
+                }
+
+                break;
+
+            case AUTH_INFO:
+
+                if (localName.equals("authorize")) {
+
+                    // Finalize mapping for this user
+                    authMapping.put(
+                        current.auth_username,
+                        current
+                    );
+
+                    state = State.USER_MAPPING;
+                    return;
+                }
+
+                break;
+                
+            case REMOTE_SERVER:
+
+                if (localName.equals("remote-server")) {
+                    state = State.AUTH_INFO;
+                    return;
+                }
+
+                break;                
+
+            case PROTOCOL:
+
+                if (localName.equals("protocol")) {
+                    state = State.REMOTE_SERVER;
+                    return;
+                }
+
+                break;
+
+            case PARAMETER:
+
+                if (localName.equals("param")) {
+                    state = State.REMOTE_SERVER;
+                    return;
+                }
+
+                break;
+
+        }
 
             throw new SAXException("Tag not yet complete: " + localName);
@@ -318 +341 @@
                     break;
 
-                // Only <authorize> tags allowed in main document
                 case USER_MAPPING:
 
@@ -350 +372 @@
                 case AUTH_INFO:
 
+                    if (localName.equals("remote-server")) {
+
+                        currentRemoteServer = attributes.getValue("servername");
+                        if (currentRemoteServer == null)
+                            throw new SAXException("Attribute \"servername\" required for param tag.");
+                        
+                        current.addConfiguration(currentRemoteServer);
+                        
+                        // Next state
+                        state = State.REMOTE_SERVER;
+                        return;
+                    }
+
+                    break;
+                    
+                case REMOTE_SERVER:
+
                     if (localName.equals("protocol")) {
                         // Next state
@@ -367 +406 @@
                     }
 
-                    break;
+                    break;                   
 
             }
@@ -379 +418 @@
 
             String str = new String(ch, start, length);
+   
             switch (state) {
 
                 case PROTOCOL:
-                    current.getConfiguration()
-                            .setProtocol(str);
+                    current.getConfiguration(currentRemoteServer)
+                        .setProtocol(str);
                     return;
 
                 case PARAMETER:
-                    current.getConfiguration()
+                    current.getConfiguration(currentRemoteServer)
                             .setParameter(currentParameter, str);
                     return;